Re: [PATCH v3] send-email: --suppress-cc improvements

From: Thomas Rast <trast@student.ethz.ch>
Date: Feb 14, 2009, 22:21 UTC
Message-ID: <200902142321.22904.trast@student.ethz.ch>
In-Reply-To: <1234631186-10179-1-git-send-email-trast@student.ethz.ch>

I just noticed that I lost the comments after '---' due to repeated format-patch'ing, so here goes:

Thomas Rast wrote:

Show 18 quoted lines

> From: Jay Soffian <jaysoffian@gmail.com>
> 
> Since 6564828 (git-send-email: Generalize auto-cc recipient
> mechanism., 2007-12-25) we can suppress automatic Cc generation
> separately for each of the possible address sources.  However,
> --suppress-cc=sob suppressed both SOB lines and body (but not header)
> Cc lines, contrary to the name.
> 
> Change --suppress-cc=sob to mean only SOB lines, and add separate
> choices 'bodycc' (body Cc lines) and 'body' (both 'sob' and 'bodycc').
> The option --no-signed-off-by-cc now acts like --suppress-cc=sob,
> which is not backwards compatible but matches the name of the option.
> 
> Also update the documentation and add a few tests.
> 
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---

I tried to address Junio's comments, mostly by reformatting the docs and expanding the tests, but also changing the handling of 'body' in the code. I also edited the patch message to my liking.

Of course your SOB above is now forged, so you'll have to ack it.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch