Re: [RFC/RFH] Fun things with git-notes, or: patch tracking backwards

From: Thomas Rast <trast@student.ethz.ch>
Date: Feb 11, 2009, 22:52 UTC
Message-ID: <200902112352.40955.trast@student.ethz.ch>
In-Reply-To: <7vprhpkgzk.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 6 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> > Right now it's just the patch-id.  Maybe filtering (author,subject)
> > and then picking the one that is the most similar could work.
> 
> Yeah, I actually was thinking about matching the (date, author) tuple and
> nothing else, as it is unlikely you would have dups.

Thanks, good idea. I changed the code to parse the required data, and we're now up to 1502 annotations.

Unfortunately I noticed there's a bug in the mail input stage: Python's mailbox module assumes any '^From ' line starts a new mail, while gmane apparently uses a slightly different format based on the double newlines too (and they always have the same 'From news@gmane.org Tue Mar 04 03:33:20 2003' separator too), and doesn't quote '^From ' in the bodies. So any mail containing such body lines got chopped down in the middle, and any patches contained in them won't apply because of the missing headers.

A quick perl run shows that there are 26 mails affected among the 89000+ mails that I've (again) imported. The fix should be easy, but I'm already short on sleep.

> I find the "Extra-Notes:" tag a bit too loud, but I am probably a minority
> who thinks everything but the Message-ID can be dropped, so please don't
> take it as a feature request ;-)

I refactored the final formatting stage a bit to let it do several notes trees, and you can now take your pick:

  git://repo.or.cz/trackgit.git notes/full
  git://repo.or.cz/trackgit.git notes/terse

The latter only has 'Message-Id' and 'Archived-At'.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch