Re: [RFC/PATCH] shortstatus v1

From: Jeff King <peff@peff.net>
Date: Feb 10, 2009, 18:22 UTC
Message-ID: <20090210182214.GA19957@coredump.intra.peff.net>
In-Reply-To: <20090210181052.GA19634@coredump.intra.peff.net>

On Tue, Feb 10, 2009 at 01:10:52PM -0500, Jeff King wrote:

Show 10 quoted lines

>   - I don't think the "mini" status is really related to this. The novel
>     thing here is collating the outputs into a single sorted list. But
>     the "mini" output is not about that at all:
> 
>       1. It doesn't care about full output, so it should be able to exit
>          early from the diff, avoid rename detection, etc, so that it is
>          as quick as possible.
> 
>       2. It doesn't collate the output at all. It is about three
>          separate symbols for the three separate lists.

Oh, sorry, I was misreading the "mini" output. I thought the three flags corresponded to the staged, unstaged, and untracked changes. But they are "unstaged or staged but added", "unstaged or staged but changed", or "untracked" (although right now the last is triggered by unmerged entries?).

I honestly don't see much point in differentiating added versus changed files. Splitting it into "some things are staged" and "some things are not staged" makes more sense to me. But if you do want that distinction then an early exit from the diff is more complicated (since you might have to keep going to see if there are any of _either_ type).

-Peff