git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Article about "git bisect run" on LWN

From
IMIngo Molnar <mingo@elte.hu>
Date
Feb 9, 2009, 12:19 UTC
Message-ID
<20090209121943.GG17782@elte.hu>
In-Reply-To
<7vskmqw1s4.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> David Symonds <dsymonds@gmail.com> writes:
> 
> > On Sat, Feb 7, 2009 at 3:41 PM, Christian Couder
> > <chriscool@tuxfamily.org> wrote:
> >
> >> It might be useful to have a list of always good commits too, and use it
> >> like this:
> >>
> >> $ git bisect start <bad> <good> $(cat always_good.txt)
> >> $ git bisect skip $(cat always_skipped.txt)
> >> $ git bisect run ./my_test_script.sh
> >
> > Your test script could just do this at its start instead:
> >
> >   if cat always_good.txt | grep $(rev-parse HEAD); then
> >     exit 0
> >   elif cat always_skipped.txt | grep $(rev-parse HEAD); then
> >     exit 125
> >   fi
> 
> Don't cat a file into grep, please.

I do it all the time not because i dont know about grep's ability to take a file parameter, but because this way it's just a special-case of command piping and i can inject other commands as i extend/edit the command line interactively, etc.

	Ingo
Previous: Junio C HamanoNext: Johannes Schindelin
Message 12 of 18 in “Article about "git bisect run" on LWN”
  1. Christian CouderFeb 5, 2009
  2. Bill LearFeb 5, 2009
  3. Ingo MolnarFeb 5, 2009
  4. david@lang.hmFeb 6, 2009
  5. Ingo MolnarFeb 6, 2009
  6. Ingo MolnarFeb 6, 2009
  7. Christian CouderFeb 6, 2009
  8. Christian CouderFeb 7, 2009
  9. David SymondsFeb 7, 2009
  10. Christian CouderFeb 7, 2009
  11. Junio C HamanoFeb 7, 2009
  12. Ingo MolnarFeb 9, 2009
  13. Johannes SchindelinFeb 9, 2009
  14. David SymondsFeb 9, 2009
  15. Christian CouderFeb 10, 2009
  16. Jonathan CorbetFeb 5, 2009
  17. Christian CouderFeb 5, 2009
  18. david@lang.hmFeb 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.