Re: Article about "git bisect run" on LWN
- From
- Ingo Molnar <mingo@elte.hu>
- Date
- Feb 9, 2009, 12:19 UTC
- Message-ID
- <20090209121943.GG17782@elte.hu>
- In-Reply-To
- <7vskmqw1s4.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> David Symonds <dsymonds@gmail.com> writes: > > > On Sat, Feb 7, 2009 at 3:41 PM, Christian Couder > > <chriscool@tuxfamily.org> wrote: > > > >> It might be useful to have a list of always good commits too, and use it > >> like this: > >> > >> $ git bisect start <bad> <good> $(cat always_good.txt) > >> $ git bisect skip $(cat always_skipped.txt) > >> $ git bisect run ./my_test_script.sh > > > > Your test script could just do this at its start instead: > > > > if cat always_good.txt | grep $(rev-parse HEAD); then > > exit 0 > > elif cat always_skipped.txt | grep $(rev-parse HEAD); then > > exit 125 > > fi > > Don't cat a file into grep, please.
I do it all the time not because i dont know about grep's ability to take a file parameter, but because this way it's just a special-case of command piping and i can inject other commands as i extend/edit the command line interactively, etc.
Ingo