Re: [JGIT] maven build fails on OS X

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Feb 6, 2009, 21:07 UTC
Message-ID: <200902062207.00941.robin.rosenberg@dewire.com>
In-Reply-To: <320075ff0902061208l6671c2a0m3d4b07b97025b53a@mail.gmail.com>

fredag 06 februari 2009 21:08:18 skrev Nigel Magnay:

Show 12 quoted lines

> > I've looked at it and gave up.  I don't know what Maven is doing here
> > on the Mac.  Maybe fresh eyes will have a better chance at fixing it.
> >
> > My experience with Maven is it works about 5% of the time, and the
> > other 95% of the time you have to work around it by skipping tests,
> > or by writing massive blocks of XML in your pom.xml file, or by
> > redesigning your entire project directory structure and revision
> > control system to use SVN instead of Git.
> 
> Ok. It's not (just) a Maven problem as I can get the same tests to
> fail in Eclipse by setting the Console Encoding to MacRoman (which is
> the default Charset.defaultCharset() when running a java app on OS X).

Ok you found it. I just sent a reply...

> However, I'm slightly confused - possibly because I don't know what
> /should/ be the case. In
> 
>  exp.replace("\303\205ngstr\303\266m", "\u00c5ngstr\u00f6m")

The text is "Ångström".

> is \303\205 really meant to represent U+00C3 and U+0085 ? Shouldn't
> the replace be being done on bytes rather than strings?

Yes, but we fake the RAW strings by only really using the lower byte of each code point. arrays of bytes are really hard to read in source code. The MacRoman is the problem. What encoding does C Git on Mac use? Isn't that UTF-8, in which case our use of platform default as fallback is wrong. Gah...

-- robin