git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] completion: Get rid of tabbed indentation in comments. Replace with spaces.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 6, 2009, 16:13 UTC
Message-ID
<20090206161303.GP26880@spearce.org>
In-Reply-To
<1233936338-10679-2-git-send-email-ted@tedpavlic.com>
Ted Pavlic <ted@tedpavlic.com> wrote:
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
Heh.

I expected Junio to use my TAB line as-is. I find them amusing. Plus, I didn't actually apply your patches and test them. They just looked right to me. Usually Acked-by is applied only if you actually ran the code and verified it does what the message claims. Trivially-acked-by is a bit less strict.

Whatever. These are really trivial patches. Whatever Junio applies here is fine.

Thanks for fixing that ${X-} thing. I clearly missed it on the review of the ps1 stuff.

-- 
Shawn.
Previous: Ted PavlicNext: Ted Pavlic
Message 7 of 9 in “completion: Fixes GIT_PS1_SHOWDIRTYSTATE problems”
  1. 0/2 completion: Fixes GIT_PS1_SHOWDIRTYSTATE problemsTed Pavlic, Feb 6, 2009
  2. 1/2 completion: Fix GIT_PS1_SHOWDIRTYSTATE to prevent unbound variable errors.Ted Pavlic, Feb 6, 2009
  3. 2/2 completion: Get rid of tabbed indentation in comments. Replace with spaces.Ted Pavlic, Feb 6, 2009
  4. Shawn O. PearceFeb 6, 2009
  5. 1/2 completion: Fix GIT_PS1_SHOWDIRTYSTATE to prevent unbound variable errors.Ted Pavlic, Feb 6, 2009
  6. 2/2 completion: Get rid of tabbed indentation in comments. Replace with spaces.Ted Pavlic, Feb 6, 2009
  7. Shawn O. PearceFeb 6, 2009
  8. Ted PavlicFeb 6, 2009
  9. Thomas RastFeb 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.