Re: [PATCH 1/2] handle color.ui at a central place

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jan 25, 2009, 14:15 UTC
Message-ID: <200901251515.55434.markus.heidelberg@web.de>
In-Reply-To: <7vk58ko8k7.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, 24.01.2009:

Show 10 quoted lines

> Markus Heidelberg <markus.heidelberg@web.de> writes:
> 
> > So with the following diff it works:
> >
> > -	if (!strcmp(var, "diff.color") || !strcmp(var, "color.diff")) {
> > +	if (!strcmp(var, "diff.color") || !strcmp(var, "color.diff")
> > +				       || !strcmp(var, "color.ui")) {
> 
> Why should format-patch need to even worry about protecting itself from
> "color.ui" to begin with?

That's the reason, why color handling needs another rework than my patch, which only was originated from the color.ui git_use_color_default workarounds. Call it shortsighted, if you want.

> If your patch is making color handling saner, I would expect that
> format-patch can *lose* the existing "ignore diff.color or color.diff"
> workaround as a result of that.  If you need to add even *more* workaround
> code like that, there's something wrong, don't you think?

That's the reason, why it doesn't make sense to continue work on my patch base.

Show 6 quoted lines

> > format-patch is perhaps the only place where the commit has broken
> > things, because I didn't find other places,...
> 
> You did not find the breakage in format-patch either to begin with; so
> your not finding does not give us much confidence that there is no other
> breakage, does it?

Of course not.

> Grumble...

Why grumble? That was just a personal suspicion. I didn't say: "I think this is the only breakage place, please reapply".