Re: [PATCH] Provide pessimistic defaults for cross compilation tests.
- From
- Ralf Wildenhues <ralf.wildenhues@gmx.de>
- Date
- Jan 20, 2009, 06:59 UTC
- Message-ID
- <20090120065939.GC5561@ins.uni-bonn.de>
- In-Reply-To
- <7vab9mpu8w.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano wrote on Tue, Jan 20, 2009 at 03:49:03AM CET:
Show 5 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > How do you deal with the hardcoded limitation that uname_S is defined to > > be the output of "uname -s" on the _build_ system, and that quite a large > > part of the Makefile sets variables dependent on this?
Oh, up to now I have blissfully ignored cross-compilation issues in git outside of configure.ac. :-)
> > IOW are you certain that configure (with your patch) will override _all_ > > uname_S dependent settings?
No, I am certain they won't override them at all.
Fixing Makefile will be more (but independent) work. All I did was get configure.ac in shape to not error out in the face of cross compilation.
Show 5 quoted lines
> It may be a valid question but it is not limited to cross compilation, is > it? The matter is if values the Makefile wants to default to can be > overriden by whatever is placed in config.mak, and as long as that is Ok > we won't have a problem with or without use of configure (which is a > second class citizen).
Yeah, I figured that. I assume it makes little sense to suggest adding AC_CANONICAL_HOST to configure.ac, letting config.{guess,sub} do their job, and the user to use "./configure --host=some-value" to specify a host alias, and then using the computed host triple to decide features, without the need to modify Makefile or other input files.
See, in a way I come from the GNU world here, and that's what I know best. Since git does its own setup here, I trust you will invent some way to solve this.
Thanks, Ralf