Re: [PATCH/RFC] shortlog: add option to group together different names/emails of an author

From: Adeodato Simó <dato@net.com.org.es>
Date: Jan 19, 2009, 14:11 UTC
Message-ID: <20090119141107.GA27992@chistera.yi.org>
In-Reply-To: <alpine.DEB.1.00.0901191445340.3586@pacific.mpi-cbg.de>

* Johannes Schindelin [Mon, 19 Jan 2009 14:49:39 +0100]:

> > Ping? I realize this may be seen as a big patch dropped out of the blue,
> > but I would very much like to hear some comments on at least the feature
> > itself, which should not take more than reading the commit message.

> This is such a huge change, for something that not many people want.  
> Actually, you seem to be the first.

That's, uhm, sad. (I don't really buy the "not many people want it, hence we should not include it" argument, unless by people you mean "people who could do a review". No hard feelings, though.)

> And you could just as well write a script that takes the output of

> 	$ git log --pretty=format:%an\ %ae --all | sort | uniq

> and constructs a valid .mailmap.  That would also have the advantage that 
> you do not need to perform the analysis each time you call Git.

No, not really. As mentioned in the commit message, .mailmap files don't help when you invoke shortlog with -e, and different email addresses for an author are involved.

> All these reasons make me believe that your patch should not be applied.

Okay, I'll let go.

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
Mankind are very odd creatures: one half censure what they practice, the
other half practice what they censure; the rest always say and do as
they ought.
                -- Michel de Montaigne