Re: [PATCH] contrib/workdir: create logs/refs and rr-cache in the origin repository

From: Adeodato Simó <dato@net.com.org.es>
Date: Jan 18, 2009, 11:38 UTC
Message-ID: <20090118113830.GA1394@chistera.yi.org>
In-Reply-To: <7vbpu54cxe.fsf@gitster.siamese.dyndns.org>

* Junio C Hamano [Sat, 17 Jan 2009 17:31:57 -0800]:

> Adeodato Simó <dato@net.com.org.es> writes:

> > If logs/refs or rr-cache are dangling symlinks in the workdir, and reflogs
> > and/or rerere are enabled, commit will die with "fatal: Could not create
> > directory". (In the case of rr-cache, it will die after having created the
> > commit.)

> > This commit just creates logs/refs and rr-cache in the origin repository if
> > they don't exist already.

> Hmm, is that better than not creating the symlink of the borrowed
> repository does not have them?

I would say so. I'll agree this covers a less common case, because one normally starts a regular repo, work on it, and at some point realize you'd like another checkout, and create a workdir. By that point, logs/refs surely should exist in the original repo.

However, I've as of late directly created bare repositories knowing that I wanted to work just with workdirs against it. In this case, the logs for each checkout'ed branch will be stored in the workdirs and not the repo, so deleting the workdir will make you lose those logs. Which is bad, since workdirs should always be safe to delete.

As I said, I realized this is a bit of a cornercase, but I think it would be nice solving in the proposed way. (If you want, I can put a shorter version of the above rationale in the commit message.)

Thanks,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
La música es de los que la quieren escuchar y de nadie más.
                -- Andrés Calamaro