git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Purest update to bash completions to prevent unbounded variable errors.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jan 13, 2009, 16:46 UTC
Message-ID
<20090113164624.GT10179@spearce.org>
In-Reply-To
<496CC3E7.8060805@tedpavlic.com>
Ted Pavlic <ted@tedpavlic.com> wrote:
Show 7 quoted lines
>> Your commit message leaves a lot to be desired.  I would instead
>> have written something like this:
>
> I agree completely. Sorry about that. stg fired off vim to edit the  
> commit message, and I just wasn't thinking.
>
> Would you like me to modify the commit message and resubmit?

You probably should, to be nice to Junio. Its far easier for the maintainer to save off well formatted messages to an mbox and run "git am" than it is to stitch it together from different emails and/or hand edit messages to make them work.

-- 
Shawn.
Previous: Ted PavlicNext: Junio C Hamano
Message 4 of 6 in “Purest update to bash completions to prevent unbounded variable errors.”
  1. 1/3 Purest update to bash completions to prevent unbounded variable errors.Ted Pavlic, Jan 13, 2009
  2. Shawn O. PearceJan 13, 2009
  3. Ted PavlicJan 13, 2009
  4. Shawn O. PearceJan 13, 2009
  5. Junio C HamanoJan 13, 2009
  6. Ted PavlicJan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.