Re: [PATCH] allow 8bit data in email body sent by send-email
- From
Jeff King <peff@peff.net>
- Date
- Jan 9, 2009, 07:28 UTC
- Message-ID
- <20090109072814.GA21180@coredump.intra.peff.net>
- In-Reply-To
- <1231422657-15305-1-git-send-email-andre.przywara@amd.com>
On Thu, Jan 08, 2009 at 02:50:57PM +0100, Andre Przywara wrote:
Show 5 quoted lines
> when sending patch files via git send-email, the perl script assumes > 7bit characters only. If there are other bytes in the body (foreign language > characters in names or translations), some servers (like vger.kernel.org) > reject the mail because of th?t. This patch always adds an 8bit header line > to each mail.
This should be done already by git-format-patch when you generate the patch to feed to send-email. What exactly is the workflow you use to generate this problem? Does it matter where the non-ascii characters are (commit versus patch, etc)? What version of git are you using?
Show 11 quoted lines
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 77ca8fe..68a462c 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -793,6 +793,7 @@ To: $to${ccline}
> Subject: $subject
> Date: $date
> Message-Id: $message_id
> +Content-Transfer-Encoding: 8bit
> X-Mailer: git-send-email $gitversion
> ";This fix isn't right anyway. For one thing, if you're going to include C-T-E, you should also include a MIME-Version header. But more importantly, we are already handling encoding elsewhere. So unconditionally adding this means that you may conflict with existing MIME headers in the @xh variable.
-Peff