[PATCH] Support ref logs for refs/*

From: Neil Macneale <mac4-git@theory.org>
Date: Jan 8, 2009, 08:28 UTC
Message-ID: <20090108082827.GA6177@tesla.theory.org>

The documentation for git update-ref seems to imply that logging of ref updates should be done for anything in refs/, though the code looks like it restricts changes to heads and remotes. Any reason not so support arbitrary refs?

I don't see much point in logging for tags, so the patch ignores refs/tags.

Thanks, Neil

Signed-off-by: Neil Macneale <mac4-git@theory.org>
---
 refs.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/refs.c b/refs.c
index 33ced65..cfff22b 100644
--- a/refs.c
+++ b/refs.c
@@ -1154,9 +1154,9 @@ static int log_ref_write(const char *ref_name, const
unsigned char *old_sha1,
        git_snpath(log_file, sizeof(log_file), "logs/%s", ref_name);
 
        if (log_all_ref_updates &&
-           (!prefixcmp(ref_name, "refs/heads/") ||
-            !prefixcmp(ref_name, "refs/remotes/") ||
-            !strcmp(ref_name, "HEAD"))) {
+           (!prefixcmp(ref_name, "refs/") ||
+            !strcmp(ref_name, "HEAD")) &&
+           prefixcmp(ref_name, "refs/tags/")) {
                if (safe_create_leading_directories(log_file) < 0)
                        return error("unable to create directory for %s",
                                     log_file);

-- 
1.6.1.141.gfe98e.dirty