Re: [PATCH] fast-export: print usage when no options specified

From: Miklos Vajna <vmiklos@frugalware.org>
Date: Jan 6, 2009, 20:11 UTC
Message-ID: <20090106201126.GJ21154@genesis.frugalware.org>
In-Reply-To: <alpine.DEB.1.00.0901062023100.30769@pacific.mpi-cbg.de>

On Tue, Jan 06, 2009 at 08:28:59PM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 8 quoted lines

> Maybe this should be part of the commit message?
> 
> -- snip --
> Some people find it surprising that fast-export does not output a usage 
> when called without parameters, as rev-list does.
> 
> This assumes that a user usually does not want to export HEAD by default.
> -- snap --

OK, if this is the only problem, I can resend it with this included. ;-)

Show 5 quoted lines

> However, I have to say that I would find exporting HEAD a rather sensible 
> default.
> 
> But I am not _that_ strongly opposed to the patch.  Just would like to 
> hear some opinions first.

According to man git, fast-export is not a plumbing, though I think most user won't type it manually multiple times, they'll write a script, that checks if there is something to convert, then run git fast-export | foo fast-import, so it's really like plumbing. That's why I found the rev-list-like behaviour more logical.

However, I think defaulting to HEAD is still better than the current situation, so if that's the consensus, I'm fine with that as well.