Re: gitweb: removal of old style blobdiff support breaks ikiwiki
- From
Jeff King <peff@peff.net>
- Date
- Jan 6, 2009, 00:25 UTC
- Message-ID
- <20090106002520.GA29000@coredump.intra.peff.net>
- In-Reply-To
- <20090105235418.GA9373@gnu.kitenet.net>
On Mon, Jan 05, 2009 at 06:54:18PM -0500, Joey Hess wrote:
> I wonder if it wouldn't be better to make gitweb continue to support the > old urls, using diff-tree instead of the porcelain?
It can't; there is currently no interface for diffing two arbitrary blobs except "git diff". The simplest fix to retain functionality but plug the hole is to pass --no-ext-diff to all versions, and --no-textconv to versions which have textconv (i.e., 1.6.1 and later). IIRC, there is a problem with --no-ext-diff in some versions, so that fix might have to be backported, too.
-Peff