Re: a few Topgit patches
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Jan 4, 2009, 13:05 UTC
- Message-ID
- <20090104130532.GA1055@pengutronix.de>
- In-Reply-To
- <20081226170334.GA18722@pengutronix.de>
Hi martin,
On Fri, Dec 26, 2008 at 06:03:34PM +0100, Uwe Kleine-König wrote:
Show 19 quoted lines
> On Thu, Dec 25, 2008 at 03:58:34PM +0100, martin f krafft wrote: > > also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2008.12.23.1530 +0100]: > > > I hacked using topgit for some time now, and found the following changes > > > to topgit useful: > > > > > > Uwe Kleine-König (3): > > > tg export: implement skipping empty patches for collapse driver > > > tg export: Implement flattening patch paths for quilt mode > > > tg export (quilt): Implement numbering the patches > > > > They all look good. I am a bit concerned about the use of > > single-letter options at this stage. tg-export is bound to grow, and > > using them all up now might mean breaking compatibility later, when > > a more common option needs e.g. -f, which has already been taken. > I updated my tree to make '-f' '--flatten'. IMHO -n is nice for getting > numbered patches, but if you prefer, I will make this --numbered. > > Oh, and I just noticed that documentation is missing. I will fix this > when I sent this mail.
This is done. Now I even changed '-n' to '--numbered' and changed the commit log accordingly. Are there still concerns about my patches? Should I resend the current version?
The patches are still available in my topgit repo at
git://git.pengutronix.de/git/ukl/topgit.git master
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Strasse 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |