Re: [EGIT PATCH] Add an import wizard for Eclipse projects as part of clone

From: Shawn O. Pearce <spearce@spearce.org>
Date: Dec 31, 2008, 15:54 UTC
Message-ID: <20081231155444.GH29071@spearce.org>
In-Reply-To: <1230720969-1735-1-git-send-email-robin.rosenberg@dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

Show 5 quoted lines

> This adds an optional page for importing Eclipse style projects
> as part of the clone operation.
> 
> This patch I think, greatly simplifies getting an Eclipse based project
> into the workbench.

Yes, yes it does!

> I'm mostly interested in comments on pure bugs. E.g. know it's
> blocking when the user selects to import the projects as part of the
> clone process, I also know I'm reusing internal messages and not supplying
> NLS style constansts for all textx.

I noticed you mispelled "showImportWizard" as "showImportWizarad", but otherwise it looks reasonable to me. I'd like to see the NLS stuff extracted out before we apply the patch though.

The blocking part is annoying, but there isn't really a better way to do it. What would be worse is going into the background, then popping open a modal dialog when it completes, as it would really disrupts the user. So just don't clone massive projects and expect to use your workbench at the same time. :-)

-- 
Shawn.