git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [STGIT][PATCH] new: translate non word characters in patch name to '-'

From
Karl Hasselström <kha@treskal.com>
Date
Dec 29, 2008, 21:21 UTC
Message-ID
<20081229212119.GA3015@diana.vm.bytemark.co.uk>
In-Reply-To
<154e089b0812291215h72dfe04aod080f665eb7f5592@mail.gmail.com>
On 2008-12-29 21:15:44 +0100, Hannes Eder wrote:
> What about instead of 'fail with an informative message', just issue
> a warning that the name has been mangled. I use pathnames in patch
> names frequently, so this would be very handy.

Hmm, I'm still skeptical. Programs that try to be too clever all too often end up just being annoying and unpredictable.

> I guess some with with more python skills needs to clean that up,
> this is the first stuff I do in python ;).

The code looks OK -- but as I said, I don't agree with what it's trying to do.

There's a small inconsistency: you fail if the name contains "..", but correct single bad characters.

And as I recall, stgit.namelength is about the automatically generated patch names -- there's no limit for the names provided by the user.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Hannes EderNext: Hannes Eder
Message 4 of 7 in “new: translate non word characters in patch name to '-'”
  1. Hannes EderDec 27, 2008
  2. Karl HasselströmDec 28, 2008
  3. Hannes EderDec 29, 2008
  4. Karl HasselströmDec 29, 2008
  5. Hannes EderDec 31, 2008
  6. Karl HasselströmDec 31, 2008
  7. David KågedalJan 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.