git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push: support full URI in handle_remote_ls_ctx()

From
Mike Hommey <mh@glandium.org>
Date
Dec 29, 2008, 07:17 UTC
Message-ID
<20081229071710.GA19175@glandium.org>
In-Reply-To
<1230517935-11299-1-git-send-email-catap@catap.ru>
On Mon, Dec 29, 2008 at 05:32:15AM +0300, Kirill A. Korinskiy wrote:
Show 36 quoted lines
> The program calls remote_ls() to get list of files from the server
> over HTTP; handle_remote_ls_ctx() is used to parse its response to
> populate "struct remote_ls_ctx" that is returned from remote_ls().
> 
> The handle_remote_ls_ctx() function assumed that the server returns a
> local path in href field, but RFC 4918 (14.7) demand of support full
> URI (e.g. "http://localhost:8080/repo.git").
> 
> This resulted in push failure (e.g. git-http-push issues a PROPFIND
> request to "/repo.git/alhost:8080/repo.git/refs/" to the server).
> 
> Signed-off-by: Kirill A. Korinskiy <catap@catap.ru>
> ---
>  http-push.c |   25 +++++++++++++++++++------
>  1 files changed, 19 insertions(+), 6 deletions(-)
> 
> diff --git a/http-push.c b/http-push.c
> index 7c6460919bf3eba10c46cede11ffdd9c53fd2dd2..a4b7d08663504a57008f66a39fffe293f62c1d08 100644
> --- a/http-push.c
> +++ b/http-push.c
> @@ -87,6 +87,7 @@ static struct object_list *objects;
>  struct repo
>  {
>  	char *url;
> +	char *path;
>  	int path_len;
>  	int has_info_refs;
>  	int can_update_info_refs;
> @@ -1424,9 +1425,19 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
>  				ls->userFunc(ls);
>  			}
>  		} else if (!strcmp(ctx->name, DAV_PROPFIND_NAME) && ctx->cdata) {
> -			ls->dentry_name = xmalloc(strlen(ctx->cdata) -
> +			char *path = ctx->cdata;
> +			if (*ctx->cdata == 'h') {
> +				path = strstr(path, "//");
I would make that a "://"
> +				if (path) {
> +					path = strchr(path+2, '/');
and s/2/3/, accordingly.

But I realize the existing code already does something like what your are doing...

Mike
Previous: Kirill A. KorinskiyNext: Kirill A. Korinskiy
Message 4 of 7 in “handle_remote_ls_ctx can parsing href starting at http://”
  1. handle_remote_ls_ctx can parsing href starting at http://Kirill A. Korinskiy, Dec 23, 2008
  2. Junio C HamanoDec 25, 2008
  3. http-push: support full URI in handle_remote_ls_ctx()Kirill A. Korinskiy, Dec 29, 2008
  4. Mike HommeyDec 29, 2008
  5. http-push: support full URI in handle_remote_ls_ctx()Kirill A. Korinskiy, Jan 2, 2009
  6. Junio C HamanoJan 2, 2009
  7. Junio C HamanoDec 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.