Re: [PATCH] fast-export: deal with tag objects that do not have a tagger
- From
Miklos Vajna <vmiklos@frugalware.org>
- Date
- Dec 18, 2008, 23:38 UTC
- Message-ID
- <20081218233843.GA21154@genesis.frugalware.org>
- In-Reply-To
- <7viqphf4ua.fsf@gitster.siamese.dyndns.org>
On Thu, Dec 18, 2008 at 03:20:29PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Such a "faking" can well be done, and should be done, on the consuming end > of the information. If you fake using the commit authorship, you would > never be able to tell from the result which one is faked and which one is > genuine. > > I think you'd rather want to see "Unspecified Tagger" in the resulting tag > object (or even better, a tag object without the tagger field created by > the fast-import process), and leave the interpretation of missing tagger > information to the consumers.
Aah, I missed that Dscho's patch will not just not die(), but it _will_ output a stream that fast-import will import. So just forget my complain. :-)
And Dscho, thanks!