Re: [PATCH] Make git revert warn the user when reverting a merge commit.
- From
Boyd Stephen Smith Jr. <bss@iguanasuicide.net>
- Date
- Dec 19, 2008, 03:29 UTC
- Message-ID
- <200812182129.01021.bss@iguanasuicide.net>
- In-Reply-To
- <7vej04eui5.fsf@gitster.siamese.dyndns.org>
On Thursday 2008 December 18 21:03:46 Junio C Hamano wrote:
Show 7 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > warning("revert on a merge commit may not do what you "
> > "expect.");
>
> [T]he new warning does
> not give you enough clue where to go next, so this warning does not give
> real value. It is pretty much meaningless noise to users.At least, it might make someone read the manpage again. Still, I'm unhappy with the message, but I didn't want to be too wordy. A URL or manpage reference would be nice, but I didn't know of a good guide that explained the dangers of reverting a merge commit as well as Linus's emails.
-- Boyd Stephen Smith Jr. ,= ,-_-. =. bss@iguanasuicide.net ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-' http://iguanasuicide.net/ \_/