git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH 1/2] Revert "Fix commit id in egit test T0001_ConnectProviderOperationTest"

From
Shawn O. Pearce <spearce@spearce.org>
Date
Dec 17, 2008, 16:09 UTC
Message-ID
<20081217160933.GD32487@spearce.org>
In-Reply-To
<1229472439-24104-2-git-send-email-robin.rosenberg@dewire.com>
Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> This reverts commit 61133091d5f22398828b350ff772165e9945db8a.
> 
> Bisect says this is the commit that failed, which is odd. Bad QA.
Hmmph.  This revert fails here.
Show 12 quoted lines
> diff --git a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
> index 0ce2d7f..aae1ef4 100644
> --- a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
> +++ b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
> @@ -99,8 +99,9 @@ assertTrue("tree missing", new File(gitDir,
>  				"objects/08/ccc3d91a14d337a45f355d3d63bd97fd5e4db9").exists());
>  		assertTrue("tree missing", new File(gitDir,
>  				"objects/9d/aeec817090098f05eeca858e3a552d78b0a346").exists());
> +
>  		assertTrue("commit missing", new File(gitDir,
> -				"objects/09/6f1a84091b90b6d9fb12f95848da69496305c1").exists());
> +				"objects/45/df73fd9abbc2c61620c036948b1157e4d21253").exists());

Debugging this test shows that the commit we created in the test is actually:

-- $ git cat-file commit 4c1bc1435f93c9409c93db5239e111271a8ccf55 tree 9daeec817090098f05eeca858e3a552d78b0a346 author J. Git <j.git@egit.org> 60876086400 +0100 committer J. Git <j.git@egit.org> 60876086400 +0100

testNewUnsharedFile

Junit tests --

Which has me starting to wonder, what the heck is different between systems that is being reflected in this commit object? The only thing I can think of is the timestamp we are creating by the deprecated Date constructor call back on line 82. Perhaps on different JVMs it is using different values for the hh:mm:ss parts of the timestamp value?

-- 
Shawn.
Previous: Robin RosenbergNext: Robin Rosenberg
Message 4 of 9 in “*** SUBJECT HERE ***”
  1. 0/2 *** SUBJECT HERE ***Robin Rosenberg, Dec 17, 2008
  2. 1/2 Revert "Fix commit id in egit test T0001_ConnectProviderOperationTest"Robin Rosenberg, Dec 17, 2008
  3. 2/2 Fixed an old failed EGit unit test.Robin Rosenberg, Dec 17, 2008
  4. Shawn O. PearceDec 17, 2008
  5. Robin RosenbergDec 17, 2008
  6. Shawn O. PearceDec 17, 2008
  7. Committer, author and tagger time should not be parsed as 32 bit signed intRobin Rosenberg, Dec 17, 2008
  8. Shawn O. PearceDec 17, 2008
  9. Robin RosenbergDec 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.