git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: fatal output from git-show really wants a terminal

From
Jeff King <peff@peff.net>
Date
Dec 15, 2008, 08:25 UTC
Message-ID
<20081215082514.GA32123@coredump.intra.peff.net>
In-Reply-To
<7v3agpzwet.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 15, 2008 at 12:15:38AM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> I haven't heard anything more about this, but if you were indeed
> discussing the change made by 61b8050, I think the fix should just be like
> this.
> [...]
> -	dup2(pager_process.in, 2);
> +	if (isatty(2))
> +		dup2(pager_process.in, 2);

I can't speak for the original poster, but I do think this behavior should be less surprising to users who perform the one particular redirection (and in the other 99% of cases, should behave exactly the same). So I think it's a positive change.

-Peff
Previous: Junio C Hamano
Message 13 of 13 in “fatal output from git-show really wants a terminal”
  1. Tim OlsenDec 10, 2008
  2. Boyd Stephen Smith Jr.Dec 10, 2008
  3. Johannes SixtDec 10, 2008
  4. Tim OlsenDec 10, 2008
  5. Boyd Stephen Smith Jr.Dec 10, 2008
  6. Boyd Stephen Smith Jr.Dec 11, 2008
  7. Jeff KingDec 11, 2008
  8. Boyd Stephen Smith Jr.Dec 11, 2008
  9. Jeff KingDec 11, 2008
  10. Junio C HamanoDec 11, 2008
  11. Junio C HamanoDec 15, 2008
  12. Junio C HamanoDec 15, 2008
  13. Jeff KingDec 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.