git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 4/5] Define Patch to parse a sequence of patch FileHeaders

From
Shawn O. Pearce <spearce@spearce.org>
Date
Dec 11, 2008, 20:27 UTC
Message-ID
<20081211202701.GI32487@spearce.org>
In-Reply-To
<200812112123.49659.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
Show 11 quoted lines
> torsdag 11 december 2008 19:39:54 skrev Shawn O. Pearce:
> > Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> > > > +		assertEquals(572, fRepositoryConfigTest.startOffset);
> > > > +		assertEquals(1490, fRepositoryConfig.startOffset);
> > >
> > > 1487 here
> > 
> > Really?  1490 is the only value that the test vector passes with.
> > What's the 3 bytes you think I'm off by?
> 
> Ah, --whitespace=fix did that.

Ok. I know you like to apply with --whitespace=fix, but I would prefer to leave these *.patch test input files[*1*] exactly as they were created by git format-patch or git diff, so I'm sure we are parsing the same thing git would have produced and sent to us.

*1*: I have more patches coming which add 2 more test inputs
     to the same PatchTest suite.
-- 
Shawn.
Previous: Robin RosenbergNext: Robin Rosenberg
Message 10 of 15 in “Patch parsing API”
  1. 0/5 Patch parsing APIShawn O. Pearce, Dec 11, 2008
  2. 1/5 Add toByteArray() to TemporaryBufferShawn O. Pearce, Dec 11, 2008
  3. 2/5 Add copy(InputStream) to TemporaryBufferShawn O. Pearce, Dec 11, 2008
  4. 3/5 Define FileHeader to parse the header block of a git diffShawn O. Pearce, Dec 11, 2008
  5. 4/5 Define Patch to parse a sequence of patch FileHeadersShawn O. Pearce, Dec 11, 2008
  6. 5/5 Add HunkHeader to represent a single hunk of a file within a patchShawn O. Pearce, Dec 11, 2008
  7. Robin RosenbergDec 11, 2008
  8. Shawn O. PearceDec 11, 2008
  9. Robin RosenbergDec 11, 2008
  10. Shawn O. PearceDec 11, 2008
  11. Robin RosenbergDec 11, 2008
  12. Shawn O. PearceDec 11, 2008
  13. Robin RosenbergDec 11, 2008
  14. Shawn O. PearceDec 11, 2008
  15. 2/5 Add copy(InputStream) to TemporaryBufferShawn O. Pearce, Dec 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.