[PATCH 1/3] gitweb: Move 'lineno' id from link to row element in git_blame
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 9, 2008, 22:46 UTC
- Message-ID
- <20081209224330.28106.18301.stgit@localhost.localdomain>
- In-Reply-To
- <20081209223703.28106.29198.stgit@localhost.localdomain>
Move l<line number> ID from <a> link element inside table row (inside cell element for column with line numbers), to encompassing <tr> table row element. It was done to make it easier to manipulate result HTML with DOM, and to be able write 'blame_incremental' view with the same, or nearly the same result.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- For blame_incremental I need easy way to manipulate rows of blame table, to add information about blamed commits as it arrives.
So there it is.
gitweb/gitweb.perl | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 6eb370d..1b800f4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4645,7 +4645,7 @@ HTML if ($group_size) { $current_color = ++$current_color % $num_colors; } - print "<tr class=\"$rev_color[$current_color]\">\n"; + print "<tr id=\"l$lineno\" class=\"$rev_color[$current_color]\">\n"; if ($group_size) { print "<td class=\"sha1\""; print " title=\"". esc_html($author) . ", $date\""; @@ -4667,7 +4667,6 @@ HTML hash_base => $parent_commit); print "<td class=\"linenr\">"; print $cgi->a({ -href => "$blamed#l$orig_lineno", - -id => "l$lineno", -class => "linenr" }, esc_html($lineno)); print "</td>";