Re: [PATCH] git-gui: Teach start_push_anywhere_action{} to notice when remote is a mirror.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Dec 2, 2008, 15:30 UTC
Message-ID: <20081202153007.GJ23984@spearce.org>
In-Reply-To: <20081202151502.3f30ced4@crow>

Mark Burton <markb@ordern.com> wrote:

Show 5 quoted lines

> When the destination repository is a mirror, this function goofed by still
> passing a refspec to git-push. Now it notices that the remote is a mirror
> and holds the refspec.
> 
> Signed-off-by: Mark Burton <markb@ordern.com>

Thanks.

Show 6 quoted lines

>  This patch stops git-gui from annoying git-push when the remote is a
>  mirror. A further enhancement would be to disable the branch names list
>  in the dialog when the selected destination is a mirror. As it stands, you can
>  select a branch name from the list but it will be ignored (this could possibly
>  confuse/annoy people). But that's a bunch more work so I'm stopping here for
>  now.

Yea, it is a chunk of work. I thought about trying to do it myself right now, but realized I won't be able to do it in 15 minutes and gave up. :-)

Unfortunately this patch adds a new string to be translated and I've already made a request for the translators to update their languages, and several have. I'll send out another request to let them know there's this new string; we should have enough time before 1.6.1 goes final.

-- 
Shawn.