Re: [PATCH 5/6 (v2)] upload-pack: send the HEAD information

From: Jeff King <peff@peff.net>
Date: Dec 2, 2008, 01:59 UTC
Message-ID: <20081202015924.GA6529@coredump.intra.peff.net>
In-Reply-To: <7vk5ajqs63.fsf@gitster.siamese.dyndns.org>

On Mon, Dec 01, 2008 at 05:31:16PM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> > Yuck. My two complaints are:
> >
> >   (1) this implicitly handles only the HEAD symref.
> 
> But this information *is* on the "40-hex name" line that describes the
> HEAD ;-)

Ahhh. OK. I see, I misunderstood the protocol a bit. So let me revise my complaints. ;)

  (1) If there are multiple symrefs to report, we have to keep
      re-sending the server capabilities (I think you mentioned this in
      the subthread with Shawn).

  (2) Similar to (2) before. If we ever add a _third_ extra slot, we
      will be stuck sending the symref field each time we want to use
      that third slot (though if the client properly treats an empty
      slot the same as non-existent, this only wastes a single byte for
      the NUL).

  (3) If HEAD doesn't point to a valid object, we have no place to put
      the symref. Or is it kosher to say

        0000000000000000000000000000000000000000 HEAD\0...\0refs/heads/master

      ? I think it would be nice eventually to be able to clone a HEAD
      pointing to yet-to-be-born branch.

-Peff