git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] gitweb: add patch view

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 29, 2008, 16:10 UTC
Message-ID
<200811291710.27891.jnareb@gmail.com>
In-Reply-To
<bd6139dc0811290743s6cf8e534nddd8a09698ea22b9@mail.gmail.com>
On Sat, 29 Nov 2008, Sverre Rabbelier wrote:
> On Sat, Nov 29, 2008 at 14:41, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
Show 9 quoted lines
> > Trying to use 'commitdiff_plain' output as input to git am results in
> > some annoying results such as doubled subject lines. We thus offer a new
> > 'patch' view that exposes format-patch output directly. This makes it
> > easier to offer patches by linking to gitweb repositories.
> 
> If this does what I think it does I would be very happy with this
> feature :). Only yesterday I wanted to link someone to a patch I put
> up on repo.or.cz, but instead ended up telling them to download the
> snapshot.

True. 'commitdiff_plain' wasn't good enough; what's more it suffers from the same ambiguity as 'commitdiff', i.e. it is both means to show diff _for_ a commit (perhaps selecting one of parents), and showing diff _between_ two commits; the new 'patch' always shows diff for a commit, or for a series of commits.

>
> As an additional feature request; would it be possible to have a view
> that exposes a patch that is directly applyable by the patch command?

Both new 'patch' ('patchset') and old 'blobdiff_plain' should be directly applicable by patch and by git-apply.

-- 
Jakub Narebski
Poland
Previous: Sverre RabbelierNext: Giuseppe Bilotta
Message 5 of 13 in “gitweb: patch view”
  1. 0/2 gitweb: patch viewGiuseppe Bilotta, Nov 29, 2008
  2. 1/2 gitweb: add patch viewGiuseppe Bilotta, Nov 29, 2008
  3. 2/2 gitweb: links to patch action in commitdiff and shortlog viewGiuseppe Bilotta, Nov 29, 2008
  4. Sverre RabbelierNov 29, 2008
  5. Jakub NarebskiNov 29, 2008
  6. Giuseppe BilottaNov 29, 2008
  7. Sverre RabbelierNov 29, 2008
  8. Jakub NarebskiNov 30, 2008
  9. Giuseppe BilottaNov 30, 2008
  10. Jakub NarebskiDec 1, 2008
  11. Giuseppe BilottaDec 1, 2008
  12. Jakub NarebskiDec 1, 2008
  13. Giuseppe BilottaDec 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.