Re: [PATCH] tg export: implement skipping empty patches for quilt mode

From: Uwe Kleine-König <ukleinek@strlen.de>
Date: Nov 26, 2008, 09:47 UTC
Message-ID: <20081126094729.GA11169@strlen.de>
In-Reply-To: <20081126092542.GE25162@piper.oerlikon.madduck.net>

On Wed, Nov 26, 2008 at 10:25:42AM +0100, martin f krafft wrote:

Show 13 quoted lines

> also sprach Uwe Kleine-König <ukleinek@strlen.de> [2008.11.25.2154 +0100]:
> > 	TODO: -n option to prevent exporting of empty patches
> > 
> > I'm not sure if this was meant for collapse or quilt or both.  I assumed
> > the last and implemented -n as suggested.
> 
> Hm, except...
> 
> +! "$skipempty" || [ "$driver" = "quilt" ] ||
> +       die "-n is only implemented for the quilt driver"
> +
> 
> so you assumed "quilt", not both.

hmm, I *implemented* it only for quilt.  That's also the reason for not
having deleted the todo item.

> Anyway, Petr, I'd make this default for all drivers, unless you object.

Ack.

If you want I can prepare a patch, but probably it's easier for you to amend!?

Best regards Uwe