Re: [TopGit PATCH] Use the topological order when exporting explicitly listed branches.
- From
- martin f krafft <madduck@debian.org>
- Date
- Nov 20, 2008, 10:54 UTC
- Message-ID
- <20081120105432.GB21374@piper.oerlikon.madduck.net>
- In-Reply-To
- <20081120102005.GB10491@machine.or.cz>
also sprach Petr Baudis <pasky@suse.cz> [2008.11.20.1120 +0100]:
> The point of -b is to export only the specified branches, assuming you > already exported the dependencies before. If you just want to export a > branch with all its dependencies, why not just switch to it and call > plain tg export?
Ah, I see. I think then I probably failed to communicate what I had in mind with -b, which was mainly to avoid use of a temporary branch where to collapse all commits before creating a series.
I don't see the point of being able to export patches into a quilt series without their dependencies. If needed, one could use tg-patch for that. The only difference between tg-export -b and tg-patch is that the former can do multiple patches in one go, and it writes a series file. Since that series is not guaranteed to be applicable, I think one could just not bother.
Thinking about it a bit more, I think tg-export should be modified such that it can always take -b/--branches, which defaults to the current branch. No matter what the driver, it always prepends the dependencies to the list. Then, the list is passed to the export driver. 'collapse' creates a branch as it does right now, and 'quilt' creates a series as it does right now.
I have most of this implemented in a branch which I'll gladly publish as soon as I figured out some remaining corner cases.
--
.''`. martin f. krafft <madduck@debian.org>
: :' : proud Debian developer, author, administrator, and user
`. `'` http://people.debian.org/~madduck - http://debiansystem.info
`- Debian - when you have better things to do than fixing systems
"zum christentum wird man nicht geboren,
man muß dazu nur krank genug sein."
- friedrich nietzsche