git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH (GITK)] gitk: Avoid handling the Return key twice in Add Branch.

From
Alexander Gavrilov <angavrilov@gmail.com>
Date
Nov 13, 2008, 20:09 UTC
Message-ID
<200811132309.18520.angavrilov@gmail.com>
This reverts commit 63767d5fb8fe236d8fdeba44297ac925701b27a0.

A similar change was made as part of commit 76f15947af7, that added bindings to all dialogs, and this duplication causes mkbrgo to be called twice, the second time after the window has been destroyed. As a result, an error window appears when the code tries to access widgets.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 gitk |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index 3353f4a..46896a2 100755
--- a/gitk
+++ b/gitk
@@ -8208,7 +8208,6 @@ proc mkbranch {} {
     grid $top.id $top.sha1 -sticky w
     label $top.nlab -text [mc "Name:"]
     entry $top.name -width 40
-    bind $top.name <Key-Return> "[list mkbrgo $top]"
     grid $top.nlab $top.name -sticky w
     frame $top.buts
     button $top.buts.go -text [mc "Create"] -command [list mkbrgo $top]
-- 
1.6.0.3.15.gb8d36
Message 1 of 1 in “gitk: Avoid handling the Return key twice in Add Branch.”
  1. gitk: Avoid handling the Return key twice in Add Branch.Alexander Gavrilov, Nov 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.