git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v3] git add -i: Answer questions with a single keypress

From
Suraj N. Kurapati <sunaku@gmail.com>
Date
Nov 5, 2008, 17:59 UTC
Message-ID
<200811050959.25824.sunaku@gmail.com>
In-Reply-To
<200811042215.31147.sunaku@gmail.com>

Allows the user to answer 'Stage this hunk' questions with a single keypress, just like in Darcs. Previously, the user was forced to press the Return key after every choice they made. This quickly becomes tiring, burdensome work for the fingers.

Signed-off-by: Suraj N. Kurapati <sunaku@gmail.com>
---
 git-add--interactive.perl |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index b0223c3..b71905e 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -877,6 +877,8 @@ sub patch_update_file {
 	$num = scalar @hunk;
 	$ix = 0;
 
+	require Term::ReadKey;
+	Term::ReadKey::ReadMode('cbreak');
 	while (1) {
 		my ($prev, $next, $other, $undecided, $i);
 		$other = '';
@@ -920,7 +922,7 @@ sub patch_update_file {
 			print;
 		}
 		print colored $prompt_color, "Stage this hunk [y/n/a/d$other/?]? ";
-		my $line = <STDIN>;
+		my $line = Term::ReadKey::ReadKey(0);
 		if ($line) {
 			if ($line =~ /^y/i) {
 				$hunk[$ix]{USE} = 1;
@@ -998,6 +1000,7 @@ sub patch_update_file {
 			}
 		}
 	}
+	Term::ReadKey::ReadMode('restore');
 
 	my $n_lofs = 0;
 	my @result = ();
-- 
1.6.0.3
Previous: Suraj N. KurapatiNext: Jeff King
Message 3 of 8 in “git-add--interactive.perl: Answer questions with a single keypress”
  1. git-add--interactive.perl: Answer questions with a single keypressSuraj N. Kurapati, Nov 5, 2008
  2. Suraj N. KurapatiNov 5, 2008
  3. Suraj N. KurapatiNov 5, 2008
  4. Jeff KingNov 6, 2008
  5. Suraj N. KurapatiNov 6, 2008
  6. Junio C HamanoNov 6, 2008
  7. Jeff KingNov 7, 2008
  8. Jeff KingNov 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.