git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] push: fix local refs update if already up-to-date

From
Jeff King <peff@peff.net>
Date
Nov 5, 2008, 02:51 UTC
Message-ID
<20081105025116.GB20907@coredump.intra.peff.net>
In-Reply-To
<20081104205743.GA26788@localhost>
On Tue, Nov 04, 2008 at 09:57:43PM +0100, Clemens Buchacher wrote:
Show 8 quoted lines
> On Mon, Nov 03, 2008 at 11:26:44PM -0500, Jeff King wrote:
> > Nit: Just reading the test, it is hard to see what is interesting about
> > it (though obviously I can blame it back to your commit :) ). Maybe a
> > more descriptive title like 'push updates uptodate local refs' would
> > make sense.
> 
> That is all I changed in this update. Pending an Ack/Nack from Jeff I feel
> that I'm done.

I have to NAK, because the extra written ref is still a problem (see my other mail). But with that fix (and I hope you both will agree with the style fixup on removing new_sha1, too), I think it should be good.

-Peff
Previous: Clemens Buchacher
Message 14 of 14 in “push: fix local refs update if already up-to-date”
  1. push: fix local refs update if already up-to-dateClemens Buchacher, Nov 4, 2008
  2. Jeff KingNov 4, 2008
  3. Junio C HamanoNov 4, 2008
  4. Clemens BuchacherNov 4, 2008
  5. Clemens BuchacherNov 4, 2008
  6. Jeff KingNov 5, 2008
  7. Clemens BuchacherNov 5, 2008
  8. 1/2 do not force write of packed refsClemens Buchacher, Nov 5, 2008
  9. 2/2 push: fix local refs update if already up-to-dateClemens Buchacher, Nov 5, 2008
  10. Clemens BuchacherNov 5, 2008
  11. Junio C HamanoNov 5, 2008
  12. Jeff KingNov 5, 2008
  13. push: fix local refs update if already up-to-dateClemens Buchacher, Nov 4, 2008
  14. Jeff KingNov 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.