Re: [PATCH 1/2] Add --verbose|-v to test-chmtime

From: Jeff King <peff@peff.net>
Date: Oct 30, 2008, 22:58 UTC
Message-ID: <20081030225850.GA3688@sigill.intra.peff.net>
In-Reply-To: <81b0412b0810300426u2ccbe51at1bf5f989b6333ed1@mail.gmail.com>

On Thu, Oct 30, 2008 at 12:26:24PM +0100, Alex Riesen wrote:

Show 6 quoted lines

> This allows us replace perl when getting the mtime of a file because
> of time zone conversions, though at the moment only one platform which
> does this has been identified: Cygwin when used with ActiveState Perl
> (as usual).
> [...]
>     test-chmtime -v +0 filename1 | cut -f 1

Personally, I would have:

  - split the argument refactoring and the addition of the "-v" argument
    into two patches to make reviewers lives easier

  - just used a special timespec that means "don't change anything, but
    show show"

but I think those are mostly nitpicks, so I am OK with the series as-is.

-Peff