[JGIT RFC PATCH 3/3] Rate limit warnings spewed by RepositoryTestCase.recursiveDelete

From: Jonas Fonseca <fonseca@diku.dk>
Date: Oct 22, 2008, 08:34 UTC
Message-ID: <20081022083420.GC17940@diku.dk>

On Windows XP / NTFS / NetBeans 6.1 / Java 5 a lot of warnings are printed. In most cases the path is in fact deleted and it seems to just be a timing bug or something Windows or NTFS specific. Also, many of the warnings are for the same paths and therefore a bit redundant. Furthermore, when a lot of warnings are printed it gives the feeling of slowing down the tests. By rate limiting the warnings the problem is still made visible for developers to notice.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
 .../org/spearce/jgit/lib/RepositoryTestCase.java   |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

 This is mostly an annoyance fix, but might be acceptable.

diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
index 9d7d133..44e24d7 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
@@ -51,6 +51,8 @@
 
 public abstract class RepositoryTestCase extends TestCase {
 
+	private static long deleteFailures;
+
 	protected final File trashParent = new File("trash");
 
 	protected File trash;
@@ -79,7 +81,7 @@ protected static void recursiveDelete(final File dir) {
 			}
 		}
 		dir.delete();
-		if (dir.exists()) {
+		if (dir.exists() && deleteFailures++ < 42) {
 			System.out.println("Warning: Failed to delete " + dir);
 		}
 	}

-- 
1.6.0.2.1166.g8d97a.dirty

-- 
Jonas Fonseca