Re: [RFC PATCH] commit: Warn about encodings unsupported by iconv.
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Oct 21, 2008, 06:17 UTC
- Message-ID
- <20081021061754.GA4656@blimp.localdomain>
- In-Reply-To
- <7vmygy233r.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Tue, Oct 21, 2008 02:39:36 +0200:
Show 7 quoted lines
> I actually have an alternative approach to suggest. > > How about adding a new i18n.commit-reencode-logmessage option (boolean), > and when it is set, we actually re-encode from i18n.commitencoding to > "utf-8" before creating the commit object (and obviously we do not store > "encoding" header in the resulting commit)? When the conversion fails, we > know it failed, so the warning you added does make sense in that context.
Maybe make the option a string, and allow to choose the target encoding (not only utf8, but anything user wishes)?