Re: [PATCH/RFR&A] Do not rename read-only files during a push
- From
Johannes Sixt <johannes.sixt@telecom.at>
- Date
- Oct 19, 2008, 17:41 UTC
- Message-ID
- <200810191941.46986.johannes.sixt@telecom.at>
- In-Reply-To
- <7v63np83mw.fsf@gitster.siamese.dyndns.org>
On Sonntag, 19. Oktober 2008, Junio C Hamano wrote:
Show 6 quoted lines
> From: Petr Baudis <pasky@suse.cz> > > Win32 does not allow renaming read-only files (at least on a Samba > share), making push into a local directory to fail. Thus, defer > the chmod() call in index-pack.c:final() only after > move_temp_to_file() was called.
Concerning the Win32 aspect of this patch:
Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
-- Hannes