Re: What's cooking in git.git (Oct 2008, #03; Tue, 14)

From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Oct 18, 2008, 20:12 UTC
Message-ID: <200810182212.47166.johannes.sixt@telecom.at>
In-Reply-To: <48F5AB87.4080409@viscovery.net>

On Mittwoch, 15. Oktober 2008, Johannes Sixt wrote:

Show 11 quoted lines

> Junio C Hamano schrieb:
> > * pb/rename-rowin32 (Sun Oct 12 21:01:23 2008 -0700) 2 commits
> >  - (squash): index-pack: do not unconditionally make packfile read-
> >    only
> >  - Do not rename read-only files during a push
> >
> > Supposedly fixes pack file renames on Windows.  The (squash) patch is my
> > attempt to fix its breakage.
>
> I'm afraid I can't reproduce the problem that the commit message
> describes.

On a different system I was able to reproduce the problem, and this patch fixes it.

I tried to fix the breakage in the compat layer, but the result was too fragile (change the source to read-write before that operation, change to read-only afterwards), and this patch (including your fixup) looks much cleaner.

-- Hannes