git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 0/5] *** SUBJECT HERE ***

From
Jakub Narebski <jnareb@gmail.com>
Date
Oct 13, 2008, 11:00 UTC
Message-ID
<200810131300.35309.jnareb@gmail.com>
In-Reply-To
<1223893165-26022-1-git-send-email-giuseppe.bilotta@gmail.com>
Err... "*** SUBJECT HERE ***"? Not that it matters...
On Mon, 13 Oct 2008, Giuseppe Bilotta wrote:
> Fifth attempt for my gitweb PATH_INFO patchset, whose purpose is to
> reduce the use of CGI parameters by embedding as many parameters as
> possible in the URL path itself, provided the pathinfo feature is
> enabled.
[...]
Show 6 quoted lines
> Giuseppe Bilotta (5):
>   gitweb: parse project/action/hash_base:filename PATH_INFO
>   gitweb: generate project/action/hash URLs
>   gitweb: use_pathinfo filenames start with /
>   gitweb: parse parent..current syntax from PATH_INFO
>   gitweb: generate parent..current URLs

I like it, and with the exception of the last patch (which looks like it doesn't check if $file_name contains '..', even as it checks if $file_parent contains '..', and which probably should not esc_url) it looks OK. from (superficial) browsing through patches.

I'll try to review them soon.
-- 
Jakub Narebski
Poland
Previous: Ondrej CertikNext: Giuseppe Bilotta
Message 8 of 9 in “[PATCHv5 0/5] *** SUBJECT HERE ***”
  1. Giuseppe BilottaOct 13, 2008
  2. 1/5 gitweb: parse project/action/hash_base:filename PATH_INFOGiuseppe Bilotta, Oct 13, 2008
  3. 2/5 gitweb: generate project/action/hash URLsGiuseppe Bilotta, Oct 13, 2008
  4. 3/5 gitweb: use_pathinfo filenames start with /Giuseppe Bilotta, Oct 13, 2008
  5. 4/5 gitweb: parse parent..current syntax from PATH_INFOGiuseppe Bilotta, Oct 13, 2008
  6. 5/5 gitweb: generate parent..current URLsGiuseppe Bilotta, Oct 13, 2008
  7. Ondrej CertikOct 13, 2008
  8. Jakub NarebskiOct 13, 2008
  9. Giuseppe BilottaOct 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.