Re: [PATCHv2] gitweb: refactor input parameters parse/validation
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
Show 5 quoted lines
> Since input parameters can be obtained both from CGI parameters and
> PATH_INFO, we would like most of the code to be agnostic about the way
> parameters were retrieved. We thus collect all the parameters into the
> new %input_params hash, delaying validation after the collection is
> completed.
Show 9 quoted lines
> @@ -672,6 +694,25 @@ sub href (%) {
> ## ======================================================================
> ## validation, quoting/unquoting and escaping
>
> +sub validate_action {
> + my $input = shift || return undef;
> + return undef unless exists $actions{$action};
> + return $action;
> +}Shouldn't $action here be $input?
--
Shawn.