Re: What about renaming ga -i [r]evert to [r]eset ?

From: Jeff King <peff@peff.net>
Date: Oct 5, 2008, 16:41 UTC
Message-ID: <20081005164124.GA31903@coredump.intra.peff.net>
In-Reply-To: <20081005152654.GA13618@gmx.de>

On Sun, Oct 05, 2008 at 05:26:54PM +0200, Marc Weber wrote:

Show 6 quoted lines

> You can get the patch from git://mawercer.de/git_my_patches branch
> revert_to_reset_renaming
> 
> Maybe someone of you beeing more familiar with perl,
> git-add--interactive and git can review it maybe telling me what should
> be done so that it can be committed upstream?

Please take a look at Documentation/SubmittingPatches. In particular:

  - this change should be split into two different patches (one for
    s/revert/reset, and one for adding "checkout").

  - patches should be sent to the list for review, as described in
    SubmittingPatches

  - commit messages should be formatted in the usual git way. I.e,

      one-line description of the change

      more elaborate description of the change, including
      details of the change, but most importantly discussing
      the rationale for the change. In order for your patch to
      be accepted, you must explain _why_ you think it's a good
      idea.

-Peff