Re: [PATCH] git grep: Add "-Z/--null" option as in GNU's grep.

From: Raphael Zimmerer <killekulla@rdrz.de>
Date: Oct 1, 2008, 13:23 UTC
Message-ID: <20081001132351.GA20659@rdrz.de>
In-Reply-To: <alpine.DEB.1.00.0810011514530.22125@pacific.mpi-cbg.de.mpi-cbg.de>

On Wed, Oct 01, 2008 at 03:15:34PM +0200, Johannes Schindelin wrote:

Show 11 quoted lines

> On Wed, 1 Oct 2008, Raphael Zimmerer wrote:
> > On Tue, Sep 30, 2008 at 04:16:19PM -0700, Shawn O. Pearce wrote:
> > > Elsewhere in Git we call this "-z", like "git ls-tree -z", "git log 
> > > -z".  Should we match grep or git convention here?
> > 
> > I'd tend to grep's convention, as most options of git-grep mimic those 
> > of grep. grep uses "-z" for \0 on _input_, so that would be very 
> > confusing for grep users...
> 
> I tend to disagree.  Git is _already_ perceived as too heterogenous, and 
> we should not add to that pile.

How about discarding "-Z" from my patch, and only leave in "--null"? That removes ambiguity _and_ is compatible to GNU grep.

- Raphael