git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH, resent] fix openssl headers conflicting with custom SHA1 implementations

From
Shawn O. Pearce <spearce@spearce.org>
Date
Sep 30, 2008, 20:51 UTC
Message-ID
<20080930205122.GO21310@spearce.org>
In-Reply-To
<alpine.LFD.2.00.0809301645340.3635@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
Show 23 quoted lines
> On Tue, 30 Sep 2008, Shawn O. Pearce wrote:
> > Nicolas Pitre <nico@cam.org> wrote:
> > > On ARM I have the following compilation errors:
> > ...
> > > This is a bit ugly but given the rat nest of system includes we have I 
> > > don't know how to solve this any better.
> > 
> > Hmm.  On Linux x86 with your change:
> > 
> > In file included from imap-send.c:32:
> > cache.h: In function 'create_ce_mode':
> > cache.h:186: error: 'S_IFLNK' undeclared (first use in this function)
> > 
> > I think that last hunk which moved the openssl includes to be before
> > cache.h is the problem.
> 
> With that, my build on ARM bombs out with:
> 
>     CC imap-send.o
> In file included from /usr/include/openssl/kssl.h:71,
>                  from /usr/include/openssl/ssl.h:191,
>                  from imap-send.c:30:
> /usr/include/ctype.h:102: error: expected expression before ']' token
*sigh*

Yea, its a bit ugly due to the rats nest of system includes. Right now I don't see how we can include your patch, it breaks a major platform for us. But obviously my "fix" is also bogus and won't get ARM working again.

Any other ideas we can try?  'cause I don't have any right now.  :-|
-- 
Shawn.
Previous: Nicolas PitreNext: Jeff King
Message 4 of 11 in “fix openssl headers conflicting with custom SHA1 implementations”
  1. fix openssl headers conflicting with custom SHA1 implementationsNicolas Pitre, Sep 30, 2008
  2. Shawn O. PearceSep 30, 2008
  3. Nicolas PitreSep 30, 2008
  4. Shawn O. PearceSep 30, 2008
  5. Jeff KingOct 1, 2008
  6. Shawn O. PearceOct 1, 2008
  7. Jeff KingOct 1, 2008
  8. Shawn O. PearceOct 1, 2008
  9. Nicolas PitreOct 1, 2008
  10. Shawn O. PearceOct 1, 2008
  11. fix openssl headers conflicting with custom SHA1 implementationsNicolas Pitre, Oct 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.