Re: [PATCH] parse-opt: migrate fmt-merge-msg.

From: Pierre Habouzit <madcoder@debian.org>
Date: Sep 30, 2008, 08:40 UTC
Message-ID: <20080930084019.GB11453@artemis.corp>
In-Reply-To: <20080929163523.GC18340@spearce.org>

On Mon, Sep 29, 2008 at 04:35:23PM +0000, Shawn O. Pearce wrote:

Show 13 quoted lines

> Pierre Habouzit <madcoder@debian.org> wrote:
> > Also fix an inefficient printf("%s", ...) where we can use write_in_full.
> > 
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> > ---
> >  builtin-fmt-merge-msg.c |   50 +++++++++++++++++++++-------------------------
> >  1 files changed, 23 insertions(+), 27 deletions(-)
> 
> Near as I can tell, this is based upon a merge commit in next.
> 
> We can't do that.  Patches need to be based on master, or worst-case
> on a topic head that is in next or pu (in which case the name of
> the topic, or its tip commit, is helpful in the note).

Hmm I've always sent my patches this way, and I believe you can git am -3 them on top of master easily. I can send you the updated series if you want.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org