git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git ls-files -m --with-tree does double output

From
Jeff King <peff@peff.net>
Date
Sep 26, 2008, 22:50 UTC
Message-ID
<20080926225043.GC24817@coredump.intra.peff.net>
In-Reply-To
<87od2dv7mz.fsf@cup.kalibalik.dk>
On Wed, Sep 24, 2008 at 06:19:32PM +0200, Anders Melchiorsen wrote:
> I think that this is wrong? The combination of -m and --with-tree
> shows duplicate entries. Git 1.6.0.2.

I have confirmed this, and it looks like it has always been that way. It looks like overlay_tree_on_cache just does a read_tree to pull the tree into the index, and then we end up with duplicate entries.

I'm not too familiar with the read_tree code, so I am cc'ing Junio (who is out of touch for a little while) and Linus, who are much more clueful in this area.

It isn't clear to me which code is _supposed_ to be pulling out such duplicates here. That is, is read_tree broken, or is overlay_tree_on_cache just calling it wrong?

-Peff
Previous: Anders Melchiorsen
Message 2 of 2 in “[BUG] git ls-files -m --with-tree does double output”
  1. Anders MelchiorsenSep 24, 2008
  2. Jeff KingSep 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.