git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH (GIT-GUI)] git-gui: Add more integration options to citool.

From
Alexander Gavrilov <angavrilov@gmail.com>
Date
Sep 26, 2008, 10:19 UTC
Message-ID
<200809261419.41392.angavrilov@gmail.com>
In-Reply-To
<20080924165201.GV3669@spearce.org>
On Wednesday 24 September 2008 20:52:01 Shawn O. Pearce wrote:
Show 23 quoted lines
> Alexander Gavrilov <angavrilov@gmail.com> wrote:
> > - Make citool return nonzero exit code if it did not commit.
> > - Add a mode where it does not actually commit and simply
> >   exits with zero code. Commit message is either disabled,
> >   or simply dumped to GITGUI_EDITMSG before exiting.
> > - Add an option to immediately start it in amend mode.
> ...
> > 	I think this functionality might be useful, in particular for some of
> > 	my own scripts. But I'm not sure if this is the best way to do it.
> 
> This looks good to me, but I think we may want to add this as a
> follow-up patch.  Thoughts?
> 
> --8<--
> git-gui: Hide commit related UI during citool --nocommit
> 
> If the user started git-gui as "git citool --nocommit" then they
> don't need the new commit / amend commit radio buttons, or the sign
> off button in the UI.  Rather than use up space with options the
> user cannot activate they are simply not installed into the UI.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---

I believe that the 'Sign Off' button should better be controlled by the nocommitmsg option; otherwise this looks good to me. But I'm not the best thinker at the moment (had a cold).

Alexander
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 5 in “git-gui: Add more integration options to citool.”
  1. git-gui: Add more integration options to citool.Alexander Gavrilov, Sep 12, 2008
  2. Shawn O. PearceSep 24, 2008
  3. Alexander GavrilovSep 26, 2008
  4. Shawn O. PearceSep 26, 2008
  5. Alexander GavrilovSep 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.