Re: [StGit] kha/{safe,experimental} updated

From: Karl Hasselström <kha@treskal.com>
Date: Sep 25, 2008, 07:33 UTC
Message-ID: <20080925073349.GB27632@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0809241548t32e8ac24n3ec88698fb907764@mail.gmail.com>

On 2008-09-24 23:48:08 +0100, Catalin Marinas wrote:

Show 7 quoted lines

> 2008/9/21 Karl Hasselström <kha@treskal.com>:
>
> > Just pushed out the stack log stuff to kha/safe. It really should
> > be ready for wider use at this point, and it was getting tiresome
> > to keep rebasing it.
>
> Great work, I merged (most of) it. Many thanks.

Thanks.

Show 6 quoted lines

> > One patch is still in experimental -- it depends on a new git
> > feature that isn't in any release yet.
> [...]
> >      Read several objects at once with git cat-file --batch
>
> I skipped this one for now.

I was talking about kha/experimental~0 here; you're talking about kha/safe~0, which is kha/experimental~1. But never mind.

> I'm using Ubuntu (Hardy) and the git version is 1.5.4.3. I would
> wait until we get at least a stable git release with this feature.

I'm using it too, but I always build my own git, so I never know what version the system comes with ... but I see your point. I'll put that patch back in kha/experimental for now.

> I haven't looked in detail but can we have a way to drop back to the
> old implementation if the option isn't available?

I guess in this case we could, since if the option exists, we can use it. (The second patch is not so lucky; the flag exists since quite a while, but lacks a feature in older gits.)

Since it's just a moderate speed-up in both cases, I'm kind of inclined to just wait for relevant distributions to catch up, and avoid all the hassle.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle