git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix submodule sync with relative submodule URLs

From
Johan Herland <johan@herland.net>
Date
Sep 24, 2008, 09:31 UTC
Message-ID
<200809241131.16327.johan@herland.net>
In-Reply-To
<402731c90809240029l308726aeme14c0e7fe2d54a3c@mail.gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
---
On Wednesday 24 September 2008, David Aguilar wrote:
> Instead of just doing an "|| exit" shouldn't it report an explanation
> of the error?
> Other than that, it looks good to me.
Fixed. Thanks.
...Johan
 git-submodule.sh |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 1c39b59..f89bdbe 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -634,6 +634,15 @@ cmd_sync()
 	do
 		name=$(module_name "$path")
 		url=$(git config -f .gitmodules --get submodule."$name".url)
+
+		# Possibly a url relative to parent
+		case "$url" in
+		./*|../*)
+			url=$(resolve_relative_url "$url") ||
+				die "failed to resolve relative submodule url for '$name'"
+			;;
+		esac
+
 		if test -e "$path"/.git
 		then
 		(
-- 
1.6.0.2.463.g7f0eb
Previous: David AguilarNext: Shawn O. Pearce
Message 3 of 10 in “Fix submodule sync with relative submodule URLs”
  1. Fix submodule sync with relative submodule URLsJohan Herland, Sep 22, 2008
  2. David AguilarSep 24, 2008
  3. Fix submodule sync with relative submodule URLsJohan Herland, Sep 24, 2008
  4. Shawn O. PearceSep 24, 2008
  5. Johan HerlandSep 24, 2008
  6. David AguilarSep 25, 2008
  7. git-submodule: remove unnecessary exits when calling resolve_relative_urlDavid Aguilar, Sep 25, 2008
  8. Johannes SixtSep 25, 2008
  9. Shawn O. PearceSep 25, 2008
  10. Johan HerlandSep 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.