Re: [TopGit PATCH] tg-patch: add From/Date: line to header and print to file
- From
Petr Baudis <pasky@suse.cz>
- Date
- Sep 22, 2008, 15:39 UTC
- Message-ID
- <20080922153938.GP10360@machine.or.cz>
- In-Reply-To
- <1221818101-14333-2-git-send-email-bert.wesarg@googlemail.com>
On Fri, Sep 19, 2008 at 11:55:01AM +0200, Bert Wesarg wrote:
Show 7 quoted lines
> To make this more similar to git format-patch, I added a 'From' and > a 'Date:' header and let 'tg patch' print to a file (which is shown as output). > > Regards > Bert > > Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
I dislike the anyway completely bogus From line. If you want mbox format, you should call (hypothetical) tg mail. Also, IMHO Date: should be simply always printed at the end of the header, it's distracting if it is higher.
Also, the writing to file is confusing to me. What are you trying to achieve? If you want to export patches, why not use 'tg export' which already has this functionality? To me, 'tg patch' is basically equivalent of 'git show' for the whole branch.
-- Petr "Pasky" Baudis The next generation of interesting software will be done on the Macintosh, not the IBM PC. -- Bill Gates