git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] Windows: Add workaround for MSYS' path conversion

From
Johannes Sixt <johannes.sixt@telecom.at>
Date
Sep 21, 2008, 21:57 UTC
Message-ID
<200809212357.23228.johannes.sixt@telecom.at>
In-Reply-To
<1222014278-11071-2-git-send-email-prohaska@zib.de>
On Sonntag, 21. September 2008, Steffen Prohaska wrote:
Show 12 quoted lines
> MSYS' automatic path conversion causes problems when passing paths as
> defines ('-D' arguments to the compiler).  MSYS tries to be smart and
> converts absolute paths to native Windows paths, e.g. if MSYS sees
> "/bin" it converts it to "c:/msysgit/bin".  But we want completely
> unmodified paths; e.g. if we set bindir in the Makefile to "/bin", the
> define BINDIR shall expand to "/bin".  Conversion to absolute Windows
> path will takes place later, during runtime.
>
> This commit adds a workaround by replacing "/" with its octal
> representation "\057", effectively hiding the path from MSYS' path
> conversion mechanism.  MSYS does no longer see the absolute path and
> therefore leaves it alone.
This is disgusting, don't you think so, too?

The reason that you need this patch is because you insist that paths in the Makefile remain defined as:

bindir = $(prefix)/bin mandir = $(prefix)/share/man infodir = $(prefix)/share/info gitexecdir = $(prefix)/libexec/git-core etc...

even if RUNTIME_PREFIX is enabled (and you seem to imply that $(prefix) is empty, but this is not enforced by any patch).

Wouldn't it be quite natural that enabling RUNTIME_PREFIX implies that the above paths are relative, and, therefore, the Makefile must define them as

bindir = bin mandir = share/man infodir = share/info gitexecdir = libexec/git-core etc...

because the prefix is ... determined at runtime? Now the paths should not be mangled anymore.

-- Hannes
Previous: Steffen Prohaska
Message 11 of 11 in “prefix discovery at runtime (on Windows)”
  1. 0/7 prefix discovery at runtime (on Windows)Steffen Prohaska, Sep 21, 2008
  2. 1/7 Windows: Add workaround for MSYS' path conversionSteffen Prohaska, Sep 21, 2008
  3. 2/7 system_path(): Add prefix computation at runtime if RUNTIME_PREFIX setSteffen Prohaska, Sep 21, 2008
  4. 3/7 Refactor git_set_argv0_path() to git_extract_argv0_path()Steffen Prohaska, Sep 21, 2008
  5. 4/7 Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.Steffen Prohaska, Sep 21, 2008
  6. 5/7 Add calls to git_extract_argv0_path() in programs that call git_config_*Steffen Prohaska, Sep 21, 2008
  7. 6/7 Modify setup_path() to only add git_exec_path() to PATHSteffen Prohaska, Sep 21, 2008
  8. 7/7 Windows: Revert to default paths and convert them by RUNTIME_PREFIXSteffen Prohaska, Sep 21, 2008
  9. Johannes SixtSep 21, 2008
  10. Steffen ProhaskaSep 22, 2008
  11. Johannes SixtSep 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.